Reduce cloning in operators #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than forwarding everything to references, which must then clone to do the actual operation, we'll go the other way -- clone references to values, then operators by value can mostly do their work directly.
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jan 26, 2018
14: Reduce cloning in operators r=cuviper a=cuviper Rather than forwarding everything to references, which must then clone to do the actual operation, we'll go the other way -- clone references to values, then operators by value can mostly do their work directly. A few of the op-assign implementations can also reduce cloning by using more op-assign themselves.
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than forwarding everything to references, which must then clone to
do the actual operation, we'll go the other way -- clone references to
values, then operators by value can mostly do their work directly.
A few of the op-assign implementations can also reduce cloning by using
more op-assign themselves.