Implement OpAssign for Complex #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#186's revival. This PR has not properly taken the previous given feedback in review, it should be incorporated. Go for more consistent requirement of Assign traits. |
|
Are you opposed to now adding a |
|
NumAssign sounds great. |
|
|
|
Can you update this to use |
|
Would love to see this PR landing. Thanks for the effort!! |
Add tests by expanding the current a + b tests to include a += b, and so on.
cuviper
force-pushed
the
complex-opassign
branch
from
d3fb419
to
d57c0c2
Compare
|
Rebased and applied bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 12, 2017
274: Implement OpAssign for Complex r=cuviper Design choice: Use by-value forms of OpAssign and use Clone to forward the reference arguments. That matches what the other traits do (for example Add). Design choice: The complex += complex operation needs Add, not just AddAssign. The complex += real operation can use just AddAssign. You could just use Add for both, not sure which way is preferable.
Build succeeded |
|
Thank you -- I'm sorry I was absent. |
bors bot
added a commit
to rust-num/num-rational
that referenced
this pull request
Jan 26, 2018
12: Implement OpAssign for Ratio r=cuviper a=c410-f3r Copied shamelessly from [#274](rust-num/num#274) but fixes #5. There is only one problem to solve before anything. Since the implementation doesn't use the `reduce` function, it is possible to exist multiple types of zeros (`0/4`, `0/21`, `0/66`) instead of the default `0/1`, which implies in test errors like `test(_1_2, _NEG1_2, _0);`, therefore, should I rewrite the test suite to be more "zero" friendly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design choice: Use by-value forms of OpAssign and use Clone to forward the reference arguments. That matches what the other traits do (for example Add).
Design choice: The complex += complex operation needs Add, not just AddAssign. The complex += real operation can use just AddAssign. You could just use Add for both, not sure which way is preferable.