Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSE feature: remove inline assembly + don't set reserved bits #105

Merged
merged 1 commit into from Apr 15, 2020

Conversation

Freax13
Copy link
Contributor

@Freax13 Freax13 commented Apr 3, 2020

  • get rid of inline assembly
  • for some reason the previous version also set bits 9 & 10 in Cr0. according to the developer manual bits 5-16 are reserved

@phil-opp phil-opp changed the title remove inline assembly + don't set reserved bits for sse SSE feature: remove inline assembly + don't set reserved bits Apr 4, 2020
@phil-opp
Copy link
Member

phil-opp commented Apr 4, 2020

Thanks a lot for the pull request!

I'm not sure why we currently set bits 9 and 10 in CR0. From a quick look at the manuals, it seems like you're right that these bits are reserved. Maybe this was a copy&paste error? Perhaps @ethindp who added this code in #77 knows more?

@phil-opp
Copy link
Member

phil-opp commented Apr 15, 2020

Given that this change only affects the SSE feature and nobody objected it, I'm going to merge it. After all, setting bits 9 and 10 seems like an accident to me.

Thanks for the PR, @Freax13!

@phil-opp phil-opp merged commit 84a7a45 into rust-osdev:master Apr 15, 2020
7 checks passed
phil-opp added a commit that referenced this pull request Apr 15, 2020
@phil-opp
Copy link
Member

phil-opp commented Apr 15, 2020

Published as version 0.9.1

@ethindp
Copy link
Contributor

ethindp commented Apr 15, 2020

@phil-opp
Copy link
Member

phil-opp commented Apr 16, 2020

Thanks for clarifying! I think as long as it still works, setting these bits was likely a copy&paste error.

vinaychandra pushed a commit to vinaychandra/bootloader that referenced this pull request May 25, 2020
vinaychandra pushed a commit to vinaychandra/bootloader that referenced this pull request May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants