Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update uefi dependency to v0.20 #360

Merged
merged 7 commits into from
Apr 13, 2023
Merged

Conversation

kennystrawnmusic
Copy link
Contributor

@kennystrawnmusic kennystrawnmusic commented Mar 27, 2023

The old version (0.18.0) of the UEFI crate that bootloader 0.11.3 depends on has code that throws a myriad of future incompatibility/deprecation warnings when compilation is attempted ― deprecation warnings that are highlighted in the rust-lang/rust#107457 tracking issue. I therefore created this pull request that both fixes the version of UEFI depended on (0.20 doesn't have the same problems) and bumps the version of bootloader to 0.11.4 to ensure that this fix gets published to crates.io immediately after it's implemented.

Copy link
Member

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! The update uefi v0.20 looks good. I left some comments inline. Once they're resolved, we can merge this.

uefi/src/main.rs Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
tests/runner/src/lib.rs Outdated Show resolved Hide resolved
tests/runner/src/lib.rs Outdated Show resolved Hide resolved
tests/runner/src/lib.rs Outdated Show resolved Hide resolved
@phil-opp phil-opp changed the title Refactor UEFI implementation for compliance with rust-lang/rust#107457 lint Update uefi dependency to v0.20 Apr 9, 2023
@kennystrawnmusic
Copy link
Contributor Author

kennystrawnmusic commented Apr 9, 2023

Thanks for the PR! The update uefi v0.20 looks good. I left some comments inline. Once they're resolved, we can merge this.

Going to do this tonight (Pacific Daylight Time/UTC-7) — with family at the moment.

kennystrawnmusic added a commit to kennystrawnmusic/cryptos that referenced this pull request Apr 12, 2023
@kennystrawnmusic
Copy link
Contributor Author

kennystrawnmusic commented Apr 13, 2023

Thanks for the PR! The update uefi v0.20 looks good. I left some comments inline. Once they're resolved, we can merge this.

Alright, just implemented your suggested changes. Sorry it took longer than expected; been very busy lately.

Copy link
Member

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@phil-opp phil-opp merged commit 63340a3 into rust-osdev:main Apr 13, 2023
@phil-opp phil-opp mentioned this pull request Apr 13, 2023
kennystrawnmusic added a commit to kennystrawnmusic/cryptos that referenced this pull request Apr 15, 2023
@phil-opp phil-opp mentioned this pull request Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants