move CStr8, CStr16, and CString16 from uefi to ucs2 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a next step, we can add more modules.
|
This is my first version, @nicholasbishop . What do you think? I think moving this out of the uefi crate is beneficial. If you like the direction, I can streamline it further. |
|
I think this is a good direction. Re CStr8, I think we should just keep it in the uefi crate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the CStr8, CStr16, and CString16 types from uefi to ucs2. The import is a 1:1 copy, but minor adjustments had to be made to be compatible with the new crate structure.
It may be a little inconsistent to have
Cstr8for Latin 1 UEFI strings here, however. What do we want to do with that? We could rebrand the crate to "UEFI strings", and not just UCS2?