Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new diverging handler functions for exceptions classified as "abort" #109

Merged
merged 4 commits into from Dec 10, 2019

Conversation

@phil-opp
Copy link
Member

phil-opp commented Dec 10, 2019

Exceptions such as double faults and machine check exceptions are classified as "abort", which means that the reported stack frame might be incorrect. It is not allowed to return from such exceptions because it could cause undefined behavior.

This pull request ensures at the type system level that double fault and machine check exceptions can never return. This way, we can prevent such undefined behavior.

Closes #97.

This is a breaking change.

@phil-opp phil-opp force-pushed the diverging-handler-fns branch from d44d4b1 to e74b8f6 Dec 10, 2019
@phil-opp phil-opp changed the title Introduce new diverging handler functions for double faults and machine check exceptions Introduce new diverging handler functions for exceptions classified as "abort" Dec 10, 2019
phil-opp added 2 commits Dec 10, 2019
@phil-opp phil-opp merged commit 2b32440 into master Dec 10, 2019
4 checks passed
4 checks passed
Test (ubuntu-latest)
Details
Test (macos-latest)
Details
Test (windows-latest)
Details
Check Formatting
Details
@phil-opp phil-opp deleted the diverging-handler-fns branch Dec 10, 2019
phil-opp added a commit that referenced this pull request Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.