Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve remaining clippy warnings and add clippy job to CI #132

Merged
merged 5 commits into from
Feb 27, 2020
Merged

Resolve remaining clippy warnings and add clippy job to CI #132

merged 5 commits into from
Feb 27, 2020

Conversation

phil-opp
Copy link
Member

No description provided.

@phil-opp phil-opp changed the title Check clippy on CI Resolve remaining clippy warnings and add clippy job to CI Feb 27, 2020
@phil-opp phil-opp merged commit ba9d74a into master Feb 27, 2020
@phil-opp phil-opp deleted the clippy-ci branch February 27, 2020 13:59
phil-opp added a commit that referenced this pull request Feb 27, 2020
@phil-opp
Update changelog for #132
26f332a
@m-ou-se
Copy link
Contributor

m-ou-se commented Apr 10, 2020

Hey,

Is there a reason to use #[allow(clippy::trivially_copy_pass_by_ref)] instead of changing the (&self) to (self), other than minor chance of breakage? Maybe this is also something to change for 0.10.

@phil-opp
Copy link
Member Author

Changing this for 0.10 is a good idea! I'd be happy to merge a PR for this.

@phil-opp
Copy link
Member Author

Implemented in #147.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phil-opp @m-ou-se