Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ring-3 flag to GDT descriptor #77

Merged
merged 1 commit into from
Jun 13, 2019
Merged

Add ring-3 flag to GDT descriptor #77

merged 1 commit into from
Jun 13, 2019

Conversation

mark-i-m
Copy link
Contributor

@mark-i-m mark-i-m commented Jun 5, 2019

No description provided.

@mark-i-m
Copy link
Contributor Author

mark-i-m commented Jun 5, 2019

As per https://software.intel.com/sites/default/files/managed/39/c5/325462-sdm-vol-1-2abcd-3abcd.pdf#G43.25669

@phil-opp
Copy link
Member

Thanks a lot for the PR and sorry for the delay! Looks good to me.

bors r+

bors bot added a commit that referenced this pull request Jun 13, 2019
@bors @mark-i-m
Merge #77
2ea49b0 
77: Add ring-3 flag to GDT descriptor r=phil-opp a=mark-i-m



Co-authored-by: Mark Mansi <markm@cs.wisc.edu>
@bors
Copy link
Contributor

bors bot commented Jun 13, 2019

Build failed

  • rust-osdev.x86_64

@phil-opp
Copy link
Member

CI failure is unrelated to this PR. Let me investigate it.

@phil-opp
Copy link
Member

Found the problem. It was caused by incorrect path joining in cargo-xbuild. Fixed in rust-osdev/cargo-xbuild@a1ff033.

bors retry

bors bot added a commit that referenced this pull request Jun 13, 2019
@bors @mark-i-m
Merge #77
0718dd4 
77: Add ring-3 flag to GDT descriptor r=phil-opp a=mark-i-m



Co-authored-by: Mark Mansi <markm@cs.wisc.edu>
@bors
Copy link
Contributor

bors bot commented Jun 13, 2019

Build succeeded

  • rust-osdev.x86_64

@bors bors bot merged commit 182abd8 into rust-osdev:master Jun 13, 2019
phil-opp added a commit that referenced this pull request Jun 13, 2019
@phil-opp
Update changelog for #77
82111d1
@phil-opp
Copy link
Member

Published as version 0.7.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mark-i-m @phil-opp