Add lending-iter feature
#294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stargateur
force-pushed
the
gat_std
branch
5 times, most recently
from
36e1674
to
276112a
Compare
|
|
Wojtek242
requested changes
May 10, 2023
Oh, and please add a note to the CHANGELOG. After I merge, I will release |
I already did no ? |
Ah, sorry. Yes, you did. It just occurred to me later and I didn't check. |
|
Looks good to me. Thanks! I will merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This show how GATs can be used for our problem that lifetime of paquet is link to capture lifetime. However, this is behind a
lending-iterfeature that I think should be considered not a part of our public api.