Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline filters #56

Merged
merged 7 commits into from
Nov 28, 2020
Merged

Offline filters #56

merged 7 commits into from
Nov 28, 2020

Conversation

polachok
Copy link
Contributor

This commit adds support for compiling filters into BPF programs and offline filtering.

@polachok
Copy link
Contributor Author

@ebfull ping?

@ebfull
Copy link
Collaborator

ebfull commented Oct 18, 2016

@polachok Sorry that I haven't had time to review this! Reviewing now.

@ebfull
Copy link
Collaborator

ebfull commented Oct 18, 2016

Hm, I don't want to expose anything in raw in the public API if possible, so I'd rather have a wrapper type. And I need to double-check that the Clone impl is memory-safe.

@polachok
Copy link
Contributor Author

Thanks for reviewing!

I don't quite follow, I think I only expose wrapper types (raw fields are not pub):

https://github.com/ebfull/pcap/pull/56/files#diff-b4aea3e418ccdb71239b96952d9cddb6R796

@ebfull
Copy link
Collaborator

ebfull commented Oct 18, 2016

Ah, sorry. I misread.

@aldanor
Copy link
Collaborator

aldanor commented Mar 12, 2017

Hi @polachok, wondering if this PR is still relevant? If so, it needs some tests (and a rebase on the latest master).

@polachok
Copy link
Contributor Author

polachok commented Mar 16, 2017

Yes, it's still relevant, we use it in https://github.com/LTD-Beget/syncookied. What kind of tests do you need?

@bvandersloot
Copy link

Just commenting as another party that thinks this is a very useful feature. I'm running my project off of @polachok's branch until this is merged.

@ebfull
Copy link
Collaborator

ebfull commented Aug 4, 2017

My next priority is to review and merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants