-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offline filters #56
Offline filters #56
Conversation
@ebfull ping? |
@polachok Sorry that I haven't had time to review this! Reviewing now. |
Hm, I don't want to expose anything in |
Thanks for reviewing! I don't quite follow, I think I only expose wrapper types (raw fields are not pub): https://github.com/ebfull/pcap/pull/56/files#diff-b4aea3e418ccdb71239b96952d9cddb6R796 |
Ah, sorry. I misread. |
Hi @polachok, wondering if this PR is still relevant? If so, it needs some tests (and a rebase on the latest master). |
Yes, it's still relevant, we use it in https://github.com/LTD-Beget/syncookied. What kind of tests do you need? |
Just commenting as another party that thinks this is a very useful feature. I'm running my project off of @polachok's branch until this is merged. |
My next priority is to review and merge this. |
This commit adds support for compiling filters into BPF programs and offline filtering.