Use AtomicPtr instead of AtomicUsize for Weak #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows Strict Provenance to work properly, fixing #262. It also now matches what `libstd` does: https://github.com/rust-lang/rust/blob/9f7e997c8bc3cacd2ab4eb75e63cb5fa9279c7b0/library/std/src/sys/unix/weak.rs#L85-L141 Also, while reading the `libstd` code, I noticed that they use an `Acquire` fence and `Release` store as the returned pointer should have "consume" semantics. I changed our code to do something slightly stronger (Acquire load and Release store) for consistancy. Signed-off-by: Joe Richey <joerichey@google.com>
|
CC @nvzqz if you want to take a look. |
josephlr
force-pushed
the
strict_prov
branch
2 times, most recently
from
214a4a2
to
0498e88
Compare
Signed-off-by: Joe Richey <joerichey@google.com>
nvzqz
approved these changes
Jun 7, 2022
fbstj
reviewed
Jun 7, 2022
newpavlov
approved these changes
Jun 7, 2022
Co-authored-by: Joe ST <joe@fbstj.net>
This means: - Relaxed Load - Release Store - Acquire fence when returning pointer Signed-off-by: Joe Richey <joerichey@google.com>
josephlr
force-pushed
the
strict_prov
branch
2 times, most recently
from
2085d7d
to
0b03f3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #262
This allows Strict Provenance to work properly. It also now matches what
libstddoes:https://github.com/rust-lang/rust/blob/9f7e997c8bc3cacd2ab4eb75e63cb5fa9279c7b0/library/std/src/sys/unix/weak.rs#L85-L141
Also, while reading the
libstdcode, I noticed that they use anAcquirefence andReleasestore as the returned pointer should have "consume" semantics. I changed our code to do something slightly stronger (Acquire load and Release store) as it's simpler and definitely correct.Signed-off-by: Joe Richey joerichey@google.com