Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TransferType Enum #136

Merged
merged 2 commits into from
May 9, 2023
Merged

Update TransferType Enum #136

merged 2 commits into from
May 9, 2023

Conversation

fchabouis
Copy link
Contributor

According to the GTFS documentation, an empty value for a transfer_type is equivalent to 0.

Also, values 4 and 5 were not implemented.

I think only a custom deserialization is needed for this Enum, and a Serialization is not necessary, am I right?

antoine-de
antoine-de approved these changes May 9, 2023
View reviewed changes
Copy link
Collaborator

@antoine-de antoine-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, I think that's fine, thanks 👍

@fchabouis fchabouis merged commit a4ef4a5 into main May 9, 2023
@fchabouis
Copy link
Contributor Author

Thanks @antoine-de !

@antoine-de antoine-de mentioned this pull request Jun 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoine-de antoine-de antoine-de approved these changes

@Tristramg Tristramg Awaiting requested review from Tristramg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fchabouis @antoine-de