Derive PartialEq, Eq, PartialOrd, Ord, Hash #68
Conversation
|
lgtm, just a formatting problem looks like |
|
@chrysn you going to update this? Looks like it's just a style issue causing the failure |
chrysn
force-pushed
the
derive-partialeq-etc
branch
2 times, most recently
from
d10024d
to
829c48a
Compare
|
Thanks for the nudge, fixed. The branch is not "up to date before merging" as GitHub configs call it, but I don't think that's a necessary step if we enable merge queues. Mind if we enable that? Then we get both the branch-is-checked-to-work-with-latest-master property and the branch-starts-from-where-the-author-started-it property. |
|
I haven't played with the merge queue stuff, but I'm fine with giving it a go. |
|
why not just update this branch? |
|
@chrysn I found myself needing to match on uX types today...can we get this in? Could just rebase on top of master |
|
@chrysn bump |
|
I've enabled the merge queue feature, which should give us a semantically correct merge history -- but for some reason the individual checks don't get kicked off. Therefore, disabling mere queues again, rebasing this branch. Not happy with this situation, but not investing too much time in understanding GitHub either. |
The derived implementations work now that the interior value is always fully masked[1]. As a side effect, this makes consts eligible for pattern matching. [1]: rust-ux#65 Closes: rust-ux#66
chrysn
force-pushed
the
derive-partialeq-etc
branch
from
829c48a
to
81871d0
Compare
The derived implementations work now that the interior value is always fully masked (#65).
As a side effect, this makes consts eligible for pattern matching.
Close: #66