Deprecate GuestMemory stopgap "iterator" methods
#133
Labels
Comments
2 tasks
jiangliu
pushed a commit
that referenced
this issue
Mar 11, 2021
* Deprecates `with_regions` `with_regions_mut` and `map_and_fold`. * Update unit tests Signed-off-by: defunct <defunct@defunct.io> Resolves #133
likebreath
added a commit
to likebreath/cloud-hypervisor
that referenced
this issue
May 27, 2021
Function "GuestMemory::with_regions(_mut)" were mainly temporary methods to access the regions in `GuestMemory` as the lack of iterator-based access, and hence they are deprecated in the upstream vm-memory crate [1]. [1] rust-vmm/vm-memory#133 Signed-off-by: Bo Chen <chen.bo@intel.com>
likebreath
added a commit
to likebreath/cloud-hypervisor
that referenced
this issue
May 27, 2021
Function "GuestMemory::with_regions(_mut)" were mainly temporary methods to access the regions in `GuestMemory` as the lack of iterator-based access, and hence they are deprecated in the upstream vm-memory crate [1]. [1] rust-vmm/vm-memory#133 Signed-off-by: Bo Chen <chen.bo@intel.com>
likebreath
added a commit
to likebreath/cloud-hypervisor
that referenced
this issue
May 27, 2021
Function "GuestMemory::with_regions(_mut)" were mainly temporary methods to access the regions in `GuestMemory` as the lack of iterator-based access, and hence they are deprecated in the upstream vm-memory crate [1]. [1] rust-vmm/vm-memory#133 Signed-off-by: Bo Chen <chen.bo@intel.com>
likebreath
added a commit
to likebreath/cloud-hypervisor
that referenced
this issue
May 27, 2021
Function "GuestMemory::with_regions(_mut)" were mainly temporary methods to access the regions in `GuestMemory` as the lack of iterator-based access, and hence they are deprecated in the upstream vm-memory crate [1]. [1] rust-vmm/vm-memory#133 Signed-off-by: Bo Chen <chen.bo@intel.com>
likebreath
added a commit
to likebreath/cloud-hypervisor
that referenced
this issue
May 31, 2021
Function "GuestMemory::with_regions(_mut)" were mainly temporary methods to access the regions in `GuestMemory` as the lack of iterator-based access, and hence they are deprecated in the upstream vm-memory crate [1]. [1] rust-vmm/vm-memory#133 Signed-off-by: Bo Chen <chen.bo@intel.com>
likebreath
added a commit
to likebreath/cloud-hypervisor
that referenced
this issue
Jun 1, 2021
Function "GuestMemory::with_regions(_mut)" were mainly temporary methods to access the regions in `GuestMemory` as the lack of iterator-based access, and hence they are deprecated in the upstream vm-memory crate [1]. [1] rust-vmm/vm-memory#133 Signed-off-by: Bo Chen <chen.bo@intel.com>
likebreath
added a commit
to likebreath/cloud-hypervisor
that referenced
this issue
Jun 2, 2021
Function "GuestMemory::with_regions(_mut)" were mainly temporary methods to access the regions in `GuestMemory` as the lack of iterator-based access, and hence they are deprecated in the upstream vm-memory crate [1]. [1] rust-vmm/vm-memory#133 Signed-off-by: Bo Chen <chen.bo@intel.com>
rbradford
pushed a commit
to cloud-hypervisor/cloud-hypervisor
that referenced
this issue
Jun 3, 2021
Function "GuestMemory::with_regions(_mut)" were mainly temporary methods to access the regions in `GuestMemory` as the lack of iterator-based access, and hence they are deprecated in the upstream vm-memory crate [1]. [1] rust-vmm/vm-memory#133 Signed-off-by: Bo Chen <chen.bo@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
with_regions,with_regions_mutandmap_and_foldwere just papering over the lack of iterator-based access to the regions inGuestMemory. After #130 closes out #8, they will no longer be needed and should be deprecated and eventually removed.The text was updated successfully, but these errors were encountered: