Remove GuestMemoryIterator, replace with GAT
#278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadowCurse
approved these changes
Sep 12, 2024
roypat
force-pushed
the
simplify-iterator
branch
from
2f8ae4b
to
bc7ea1c
Compare
roypat
changed the title
GuestMemoryIterator, replace with GATGuestMemoryIterator, replace with GAT
Use an implicit generic associated type to realize GuestMemory::iter(). This removes the pre-GAT workaround used here to get an iterator that borrows values with the same lifetime as the `&self` parameter to `.iter()`. Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat
force-pushed
the
simplify-iterator
branch
from
bc7ea1c
to
2383324
Compare
|
@stefano-garzarella what do you think about this? I compiled both vm-virto and vhost workspaces against this without issues, and now that Rust 1.75.0 and impl-trait-in-trait have been out for a while, I think it's a nice simplification we can make |
|
@roypat I'm not a vm-memory expert, but I like this simplification, especially if it does not require changes from crate users! |
stefano-garzarella
approved these changes
Oct 2, 2024
rbradford
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use an implicit generic associated type to realize GuestMemory::iter(). This removes the pre-GAT workaround used here to get an iterator that borrows values with the same lifetime as the
&selfparameter to.iter().This is a follow up from a discussion between @Ablu and me on Slack. I was cleaning up my workspace and decided to just put it out here to get some comments. Note that this requires rustc 1.75.0 to compile.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commitmessage has max 60 characters for the summary and max 75 characters for each
description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.