Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 0.4 -> 0.5 not a breaking change by adding deprecated items #99

Closed
wants to merge 1 commit into from

Conversation

madsmtm
Copy link
Member

@madsmtm madsmtm commented Aug 10, 2022

Solves rust-windowing/winit#2415.

After this, we can then release v0.4.4 as just a re-export of v0.5.1.

Of course we will have to remove these at some point, but at least it can wait until the next major release, at which point we may be ready to declare a v1.0 and won't have to deal with breaking changes any more.

CC @rib @maroider @kchibisov

@rib
Copy link

rib commented Aug 10, 2022

Just to be clear here though; to support backwards compatibility I think this approach also requires Winit to fill in those deprecated window-handle struct members right?

As in doesn't provide transparent compatibility between Winit based on raw_window_handle 0.5 (which only puts the display state in the display handles currently) and something like Wgpu 0.13 that wants window-handles that contain display state.

@madsmtm
Copy link
Member Author

madsmtm commented Aug 10, 2022

Just to be clear here though; to support backwards compatibility I think this approach also requires Winit to fill in those deprecated window-handle struct members right?

As in doesn't provide transparent compatibility between Winit based on raw_window_handle 0.5 (which only puts the display state in the display handles currently) and something like Wgpu 0.13 that wants window-handles that contain display state.

Yeah, that would be required, though winit would be able to drop support for it e.g. in v0.28.0, when it is expected that wgpu and such have updated to raw-window-handle v0.5

@maroider
Copy link
Member

I think it makes the most sense to move forward with rust-windowing/winit#2418 at this point.

@kchibisov
Copy link
Member

Closing in favor of winit patches.

@kchibisov kchibisov closed this Aug 11, 2022
@madsmtm madsmtm deleted the not-breaking branch August 11, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

4 participants