Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4k HiDPI monitor detected as 2560x1440 on Windows 10 #469

Closed
eterevsky opened this issue Apr 17, 2018 · 6 comments · Fixed by #548
Closed

4k HiDPI monitor detected as 2560x1440 on Windows 10 #469

eterevsky opened this issue Apr 17, 2018 · 6 comments · Fixed by #548
Labels
B - bug Dang, that shouldn't have happened C - in progress Implementation is proceeding smoothly D - hard Likely harder than most tasks here DS - windows P - high Vital to have
Milestone

Comments

@eterevsky
Copy link

OS: Windows 10 Home, Version 1708, build 16299.371
winit version: 0.11.3
GPU: Nvidia GTX 1080, driver 385.54
Scaling factor: 150%

events_loop.get_primary_monitor()

produces MonitorId with name = "\.\DISPLAY1", dimensions = (2560, 1440), position = (0, 0), hidpi_factor = 1

winit::WindowBuilder::new().with_fullscreen(Some(events_loop.get_primary_monitor()))

changes monitor resolution to 2560x1440 instead of using native 3840x2160.

@francesca64
Copy link
Member

With #457, setting fullscreen doesn't change monitor resolution at all, so optimistically that's fixed there too.

@eterevsky
Copy link
Author

On master only the first part of the issue can be reproduced, i.e. a 4k monitor is reported as having dimensions 2560x1440 and scale factor 1 instead of 1.5. However, creating a fullscreen window doesn't change the resolution, which is nice.

@francesca64
Copy link
Member

That sounds like it's probably related to DPI awareness, which there's a seemingly abandoned PR for (#332). Getting that ready for merge is on my to-do list, so I'll let you know when that happens.

@kwonoj
Copy link
Contributor

kwonoj commented May 3, 2018

I'm interested in this issue as well, curious plans around #332 - allows some other contributor than the original author could possibly try to rebase to master and create new PR or honor and wait for original author or owner chimes in? @francesca64

@francesca64
Copy link
Member

@kwonoj I've been planning on rebasing it myself. I've just been busy working on other improvements, so it's been pushed back a few times. I should be able to start working on it today though.

@francesca64 francesca64 added B - bug Dang, that shouldn't have happened C - in progress Implementation is proceeding smoothly D - hard Likely harder than most tasks here P - high Vital to have labels May 6, 2018
@francesca64 francesca64 added this to the HiDPI Support milestone May 6, 2018
@francesca64
Copy link
Member

This took much longer than I thought it would, but you'll see why when you see the PR: #548

tmfink pushed a commit to tmfink/winit that referenced this issue Jan 5, 2022
…land-implementation, r=jdm

Fix Cohen-Sutherland algorithm implementation for d3d9

Fix the artifact caused by view box clipping on d3d9 level. Note that d3d11 doesn't have this issue.

![clipping_issue](https://user-images.githubusercontent.com/28705694/125883499-53ea8660-f7e2-43a5-ab27-8f820da9a05a.gif)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B - bug Dang, that shouldn't have happened C - in progress Implementation is proceeding smoothly D - hard Likely harder than most tasks here DS - windows P - high Vital to have
Development

Successfully merging a pull request may close this issue.

4 participants