Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Specify to build winit package when invoking cargo-apk #2561

Merged
merged 3 commits into from
Nov 24, 2022
Merged

ci: Specify to build winit package when invoking cargo-apk #2561

merged 3 commits into from
Nov 24, 2022

Commits on Nov 23, 2022

  1. ci: Don't use $CMD for Android doc building 

    Since migrating `cargo-apk` to `clap` [it is now annoying] to pass
unknown arguments to an underlying `cargo` command (like `cargo doc`):
fortunately generating docs doesn't need to go through `cargo apk` to
set up cross-compiler/linker environment variables at all.

[it is now annoying]: rust-mobile/ndk#363
    @MarijnS95
    MarijnS95 committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    4b71016 View commit details
    Browse the repository at this point in the history

  2. ci: Simplify

    @MarijnS95
    MarijnS95 committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    58bf5b9 View commit details
    Browse the repository at this point in the history

  3. ci: Explicitly build just the winit package on Android 

    Since rust-mobile/cargo-subcommand#23 `cargo-apk`
now strictly searches for workspaces first before committing to finding
the right package _within said workspace_, and bails when no package was
selected since we don't support selecting (building, packaging, running)
>1 target currently.

Perhaps it's a bit hash to enforce this on free-form `cargo apk --`
invocations, but it is what it is.
    @MarijnS95
    MarijnS95 committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    c3f4868 View commit details
    Browse the repository at this point in the history