Implement X11 extensions using x11rb instead of Xlib #2968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Weirdly, it looks like device handling is pretty tightly kneaded into Xlib's event handling, so I can't take it out until #2767 merges. So I guess what's here is what's here. |
kchibisov
requested changes
Jul 22, 2023
notgull
force-pushed
the
x11-extensions
branch
2 times, most recently
from
d881bfd
to
9a06c2d
Compare
5 tasks
kchibisov
requested changes
Aug 27, 2023
Removes Xlib code by replacing it with the x11rb equivalent. Signed-off-by: John Nunley <dev@notgull.net>
Signed-off-by: John Nunley <dev@notgull.net>
Transfers more functionality from Xlib to x11rb
It seems that Xlib's event code ignores device events if I don't do this. Once rust-windowing#2767 is merged we can work around this issue.
Signed-off-by: John Nunley <dev@notgull.net>
Signed-off-by: John Nunley <dev@notgull.net>
notgull
force-pushed
the
x11-extensions
branch
from
422d27b
to
d7323de
Compare
kchibisov
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdif knowledge of this change could be valuable to usersPorts the code for the XInput and XRandr to use
x11rbinstead of Xlib.Draft because there's still more to do, and also I seem to have broken raw event inputs.