Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(changelog): write migrations for 0.30 #3614

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

kchibisov
Copy link
Member

@kchibisov kchibisov commented Mar 28, 2024

Add a migrations for the big API changes showcasing how to upgrade some common snippets of old code to new APIs.

Blocked on #3590.

@kchibisov kchibisov added the C - nominated Nominated for discussion in the next meeting label Mar 29, 2024
@kchibisov
Copy link
Member Author

TODO: Add a link why certain thing was changed.

@kchibisov kchibisov removed the C - nominated Nominated for discussion in the next meeting label Mar 29, 2024
Copy link
Member

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would prefer sticking to #3612.

@kchibisov
Copy link
Member Author

we've discussed that with @madsmtm and my only issue with his patch was that it was too long and more informal. Things already happened, so you should say how to do and be more incremental. Anyway, do with this PR whatever you both want.

@madsmtm
Copy link
Member

madsmtm commented Apr 12, 2024

I incorporated some of my ideas from #3612 into this one, and opened #3626 as the place to submit feedback (feel free to edit that issue however you like).

@kchibisov kchibisov requested a review from notgull as a code owner April 12, 2024 17:27
@kchibisov kchibisov force-pushed the kchibisov/changelog-reformat branch from bc9fca3 to 46fba81 Compare April 12, 2024 17:31
Base automatically changed from kchibisov/changelog-reformat to master April 12, 2024 17:38
Add a migrations for the big API changes showcasing how to upgrade
some common snippets of old code to new APIs.

Co-authored-by: Mads Marquart <mads@marquart.dk>
@kchibisov kchibisov merged commit 8998e36 into master Apr 12, 2024
52 checks passed
@kchibisov kchibisov deleted the kchibisov/030-migrations branch April 12, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants