Add Event::as_raw(), Connection::resolve_event() #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some ffi scenarios it is necessary to extract the underlying event pointer. The `Event::as_raw` method serves this purpose. I couldn't implement the `Raw<>` trait for `Event` because the `from_raw` method requires additional context in order to perform the inverse of the `as_raw` method, so `Event::as_raw` is just a standalone method. I added `Connection::resolve_event` as the inverse operation to give some symmetry. closes: rust-x-bindings#188
wez
added a commit
to wez/xcb-imdkit-rs
that referenced
this pull request
May 8, 2022
wez
added a commit
to wez/wezterm
that referenced
this pull request
May 8, 2022
rtbo
reviewed
May 9, 2022
rtbo
reviewed
May 9, 2022
|
LGTM besides the point about doc comment. |
|
OK! Hopefully both points are now addressed! |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some ffi scenarios it is necessary to extract the underlying
event pointer. The
Event::as_rawmethod serves this purpose.I couldn't implement the
Raw<>trait forEventbecause thefrom_rawmethod requires additional context in order to performthe inverse of the
as_rawmethod, soEvent::as_rawis justa standalone method.
I added
Connection::resolve_eventas the inverse operationto give some symmetry.
closes: #188