Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require unsafe blocks in unsafe fns #165

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Require unsafe blocks in unsafe fns #165

merged 1 commit into from
Feb 23, 2024

Conversation

FenrirWolf
Copy link
Member

Applies #![deny(unsafe_op_in_unsafe_fn)] to the whole crate, because marking unsafe code is a good idea even in unsafe functions.

@FenrirWolf FenrirWolf requested a review from a team as a code owner February 23, 2024 00:12
@FenrirWolf
Copy link
Member Author

FenrirWolf commented Feb 23, 2024 •
edited
Loading

Think I'll just merge this since, as discussed in this review thread, we already know we want it in

@FenrirWolf FenrirWolf merged commit 10163fd into rust3ds:master Feb 23, 2024
4 checks passed
@FenrirWolf FenrirWolf deleted the unsafe_blocks_in_unsafe_fn branch February 23, 2024 02:27
ian-h-chamberlain
ian-h-chamberlain reviewed Feb 25, 2024
View reviewed changes
Copy link
Member

@ian-h-chamberlain ian-h-chamberlain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ian-h-chamberlain ian-h-chamberlain ian-h-chamberlain left review comments

@AzureMarker AzureMarker Awaiting requested review from AzureMarker AzureMarker is a code owner automatically assigned from rust3ds/active

@Meziu Meziu Awaiting requested review from Meziu Meziu is a code owner automatically assigned from rust3ds/active

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FenrirWolf @ian-h-chamberlain