Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cuddly Ferris icon, generate favicon from it #3

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add cuddly Ferris icon, generate favicon from it #3

wants to merge 2 commits into from

Conversation

nbraud
Copy link
Contributor

@nbraud nbraud commented Oct 29, 2019

No description provided.

@nbraud nbraud requested a review from a team as a code owner October 29, 2019 23:53
@nbraud
Copy link
Contributor Author

nbraud commented Nov 15, 2019

icotool doesn't exist in Netlify's default container image, I'll likely have to make a custom image. >_>'

czocher
czocher reviewed Nov 17, 2019
View reviewed changes
Copy link

@czocher czocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If netlify doesn't have the icontool this PR can probably be closed?

@nbraud
Copy link
Contributor Author

nbraud commented Nov 17, 2019 •
edited
Loading

@czocher It doesn't have icotool in their default build environment, but they will happily let you choose an arbitrarish container to run the build in, so it's “just” a matter of providing a container image with the things installed. (Read: haven't bothered doing it yet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czocher czocher czocher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbraud @czocher