Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Fixes #5 #6

Merged
merged 1 commit into from
Jul 29, 2016
Merged

- Fixes #5 #6

merged 1 commit into from
Jul 29, 2016

Conversation

epinapala
Copy link
Collaborator

Add an undefined check on results[0] before accessing results[0].votes

@epinapala
Copy link
Collaborator Author

@rustinlee Can you take a look?

@rustinlee rustinlee merged commit 449a81a into rustinlee:master Jul 29, 2016
@rustinlee
Copy link
Owner

Sorry for the delay, this is a really old project I don't maintain any more -- I'll go ahead and give you push access but your time might be better spent re-writing this from scratch with current frameworks/methodologies. As far as I know a lot of the message transport logic is predicated on the pre-1.0 socket.io API which is probably 2 years old at this point, which is just one example of how outdated this codebase is.

@epinapala
Copy link
Collaborator Author

epinapala commented Jul 29, 2016

@rustinlee Thanks for the response. I am thinking to rewrite this as a slack bot. That way we can concentrate on engine logic and worry less about UI. If I do use any of your components, I will mention you in credits. Thanks for the great work!

@rustinlee
Copy link
Owner

That's a great idea; I would love to play Mafia in slack. Please keep me
updated!

On Fri, Jul 29, 2016 at 2:55 PM, Rajesh Pinapala notifications@github.com
wrote:

@rustinlee https://github.com/rustinlee Thanks for the response. I am
thinking to rewrite this as a slack bot. That way We can concentrate on
engine logic and worry less about UI. If I do use any fo your components, I
will mention you in credits. Thanks for the great work!


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#6 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADxpaO2oCBhCNWuWWVpmpgrO9RdSIoa0ks5qakyNgaJpZM4JXIK3
.

@epinapala
Copy link
Collaborator Author

Here is what I have so far - https://github.com/epinapala/mafiabot, still a lot more to do :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants