add convert module #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robatipoor
reviewed
Feb 22, 2021
Cargo.toml
Outdated
| @@ -7,5 +7,3 @@ edition = "2018" | |||
| # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html | |||
|
|
|||
| [dependencies] | |||
| lazy_static = "1.4.0" | |||
There was a problem hiding this comment.
please do not remove dependencies, we need them in the future
src/convert/mod.rs
Outdated
| src.chars() | ||
| .map(|v| { | ||
| let index = DIGITS[from as usize].iter().position(|&r| r == v); | ||
| if index.is_some() { |
There was a problem hiding this comment.
please Instead of if index.is_some() use if let Some(i) = DIGITS...
src/convert/mod.rs
Outdated
| .collect::<String>() | ||
| } | ||
|
|
||
| pub fn digits_tofa(src: &str) -> String { |
There was a problem hiding this comment.
please use snake case naming style like digits_to_fa or digits_to_farsi
src/convert/mod.rs
Outdated
| digits_convert(src, Lang::En, Lang::Fa) | ||
| } | ||
|
|
||
| pub fn digits_toen(src: &str) -> String { |
|
thanks |
omid
reviewed
Feb 24, 2021
| src.chars() | ||
| .map(|v| { | ||
| let index = DIGITS[from as usize].iter().position(|&r| r == v); | ||
| if let Some(i) = index { |
There was a problem hiding this comment.
@sina-devel We can have a match instead of this, then you can omit the return
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added convert module (digit converts) and removed unused libs