-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: updates for rustls 0.23 #9
Conversation
I hope that futures-rustls and tokio-rustls keep isomorphic in implement to reduce maintenance costs. You can refer to this to implement it. rustls/tokio-rustls#44 |
Specifically you mean adding a variant instead of using an option? Will do. Why don't these crates share code if they're intended to be largely identical? Or have one crate and enable the async traits with a feature flag? Or at the least keep them in a shared workspace folks remember to update both? I also believe there's a bug in the other implementation, in that it doesn't check if the alert returns WouldBlock and return pending. Should I PR that over there? |
Switched to using a MidHandshake::SendAlert variant instead of a |
7a754a7
to
cde4681
Compare
There are some other changes in tokio-rustls (poll_shutdown, vectored write), would you like to work on it in this PR? |
I'll take a look tonight. |
Thank you! |
This PR is an attempt at updating futures-rustls for rustls 0.23.
aws-lc-rs
to track rustls' default. (feat: change default crypto provider to match rustls' tokio-rustls#50 for parity)fips
andlogging
features so crates don't need to depend on rustls just to enable those features without using rustls directly in code (feat: add fips pass-through feature tokio-rustls#49 for parity)Adds an optional AcceptedAlert to the MidHandshake::Error stateAdds a SendAlert variant to MidHandshake per Take rustls 0.23 tokio-rustls#44, with the changes in fix: check for ErrorKind::WouldBlock in MidHandshake::SendAlert poll tokio-rustls#47Option<Error, AcceptedAlert>
on LazyConfigAcceptor in order to send the AcceptedAlert, tracking the changes in Fix: Check for ErrorKind::WouldBlock in LazyConfigAcceptor tokio-rustls#48pub(crate) common::SyncWriteAdapter
and uses it instead of an identical function-localWriter
type, tracking the changes in Take rustls 0.23 tokio-rustls#44SyncReadAdapter
instead of an identical function-localReader
type tracking the changes in Take rustls 0.23 tokio-rustls#44Let me know if you'd like me to split any of these out into distinct PRs or to back them out of this PR.