don't depend on hyper/tcp feature by default #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On fuchsia, we don't support the mio and tokio runtime yet, and so in order to use hyper-rustls, we need to compile it with `default-features = false`. Unfortunately, in rustls#96, @CryZe added a hard requirement for the hyper "tcp" feature, which pulls in the tokio runtime. To restore our ability to use hyper-rustls, this patch removes the "hyper/tcp" hard feature requirement.
erickt
force-pushed
the
no-required-tokio-rt
branch
from
f87c8b9
to
0f432b3
Compare
|
I just checked, and it actually looks like we don't even need this feature for |
|
Whoops, sorry about that ^^' |
|
@CryZe No worries! This isn't blocking us yet, I'm just doing prep work to update to hyper 0.13. Thanks for doing the upgrade! |
|
@ctz gentle ping :) |
|
Thanks @lucab! Would it be possible to also get a 0.19.1 release cut for this change? |
|
You'd need @ctz for publishing a new crate version. He usually batches GH activity around the weekend. |
|
Awesome, thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On fuchsia, we don't support the mio and tokio runtime yet, and so in order to use hyper-rustls, we need to compile it with
default-features = false. Unfortunately, in #96, @CryZe added a hard requirement for the hyper "tcp" feature, which pulls in the tokio runtime.To restore our ability to use hyper-rustls, this patch migrates the "hyper/tcp" hard feature requirement to an optional "tcp" feature. Note that we don't need to change the default case, because the "hyper/runtime" feature already depends on "hyper/tcp".