Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature for ring's less-safe-getrandom-custom-or-rdrand #224

Closed
wants to merge 1 commit into from

Conversation

coder0xff
Copy link

No description provided.

@est31
Copy link
Member

est31 commented Feb 12, 2024

I think it might be a better idea to suggest people to directly depend on ring? I'm not sure we should add feature flags for all of the feature flags of our dependencies, unless it's really a major feature.

@coder0xff
Copy link
Author

Perhaps. WebRTC is my true goal, and would have had to enable this flag. Maybe it will be easier to convince the maintainers not to use rcgen.

@est31
Copy link
Member

est31 commented Feb 12, 2024

Not that I'm not suggesting to not use rcgen at all, just to also directly depend on ring and then enable the feature there. Then it will also be enabled for the ring that rcgen uses due to dependency unification.

@coder0xff
Copy link
Author

Ok, I misunderstood. Thanks for clarifying.

@coder0xff
Copy link
Author

Curious, does that mean that my project, which uses WebRTC, could do the same, directly depend on ring to set the flag, thereby bypassing the intermediate dependencies?

@coder0xff coder0xff closed this Feb 12, 2024
@coder0xff coder0xff deleted the less-safe-ring branch February 12, 2024 04:22
@djc
Copy link
Member

djc commented Feb 12, 2024

If you're enabling features that aren't enabled by default, yes, that should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants