ci: update cargo-check-external-types toolchain, fix build #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upstream project cut a 0.1.12 release that now pins Rust nightly-2024-05-01. This commit updates CI to match.
* Updating time v0.3.34 -> v0.3.36 * Updating time-macros v0.2.17 -> v0.2.18 Fixes a build err w/ nightly of the form: ``` error[E0282]: type annotations needed for `Box<_>` ```
cpu
changed the title
cpu
force-pushed
the
cpu-fix-external-types-check
branch
from
fff36c3
to
4972f51
Compare
There's an unfixed issue with nightly rust that produces an ICE building the project w/ nightly. Pin a working version until its fixed upstream.
cpu
force-pushed
the
cpu-fix-external-types-check
branch
from
4972f51
to
edbb716
Compare
Tripping over a handful of breakages. I'll flip this back once the build is green. |
All set. |
djc
approved these changes
May 28, 2024
|
These changes are pretty small/boring, going to merge with one review to unbreak main's CI. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
est31
approved these changes
May 28, 2024
Hmm, unclear what happened here. The failed CI task ("build (ubuntu-latest, beta)") logs ended with "Error: The operation was canceled." while running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
cargo-check-external-types, the upstream project cut a 0.1.12 release that now pins Rust nightly-2024-05-01. This commit updates CI to match.For the
timedep, a bump in theCargo.lockwas required to fix the project build w/ nightly.Lastly, the project's builds of
mainusing nightly are hitting an upstream bug (rust-lang/rust#125474), take the same workaround we landed in Rustls (rustls/rustls#1971) to unbreak the build while this is sorted out.