Implement SSL_CONF_cmd VerifyMode command.
#31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We define a `_SSL_CONF_CTX_clear_flags` entrypoint, but weren't using it prior to this commit.
We already implemented `SSL_CTX_get_verify_mode` and had all the pieces laying around for the `SSL` equiv. Implementing this for `SSL` objects will make writing a unit test for a piece of the `SSL_CONF_` API easier.
An nginx integration test is blocked on implementing `SSL_CTX_set_verify`.
cpu
commented
Jun 25, 2024
This was referenced Jun 25, 2024
ctz
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch follows #29, extending the existing
SSL_CONF_xxxAPI to support the "VerifyMode" sub-command. Seeman 3 SSL_CONF_cmd& ctrl-f "VerifyMode" (my kingdom for an anchor tag 🙄), for more information.Similar to the existing support for
SSL_CTX_set_verifyandSSL_set_verifywe supportPeer,RequestandRequirebut notOnce,RequestPostHandshakeorRequiresPostHandshake.Along the way I also:
SSL_CONF_CTX_clear_flagsentrypoint. The implementation landed in Start of SSL_CONF_* API support, Ubuntu 24.04 in CI #29 but wasn't being demangled by the linker build script to expose it. It's now used in theconfig.cunit test so we won't regress by mistake.SSL_get_verify_mode. We already implementedSSL_CTX_get_verify_modeand had all the pieceslaying around for the
SSLequiv. I also needed this for the update to theconfig.cunit tests.There's no nginx integration test for this one because I believe we need #15 to get that working.
Updates #22