Use end_entity variable when verifying CertificateVerify
#1799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function very nicely constructs the `end_entity` variable, use it throughout instead of selecting it again. This makes it so that we use the position of `end_entity` in the chain only once, and it makes it more clear that we're using the previously-verified certificate.
thomwiggers
force-pushed
the
use-explicit-end-entity
branch
from
9ef2466
to
4d01019
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1799 +/- ##
=======================================
Coverage 96.02% 96.02%
=======================================
Files 81 81
Lines 18678 18678
=======================================
Hits 17935 17935
Misses 743 743 ☔ View full report in Codecov by Sentry. |
Benchmark resultsInstruction countsSignificant differencesThere are no significant instruction count differences Other differencesClick to expand
Wall-timeSignificant differencesClick to expand
Other differencesClick to expand
Additional informationCheckout details:
|
|
Also, a surprisingly large performance win! |
|
That is odd, because it includes places where this code isn't even used 🤨 |
|
Measuring performance is very hard and weird---maybe the small difference in codegen somehow results in other code getting aligned differently or something |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function very nicely constructs the
end_entityvariable, use it throughout instead of selecting it again.This makes it so that we use the position of
end_entityin the chain only once, and it makes it more clear that we're using the previously-verified certificate.