Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPS All The Things #608

Merged
merged 2 commits into from
Jun 11, 2019
Merged

HTTPS All The Things #608

merged 2 commits into from
Jun 11, 2019

Conversation

Jake-Shadle
Copy link
Contributor

When deploying some locally generated documentation to netlify, netlify was "helpfully" spewing out warnings such as this

6:05:35 PM: Mixed content detected in: /nalgebra/base/allocator/type.sameshapec.html
6:05:35 PM: --> insecure link urls:
6:05:35 PM:   - http://nalgebra.org/img/favicon.ico

And indeed, the nalegbra site itself has a similar warning about insecure content, at least in Firefox.

image

image

So this change just basically turns all of the http:// links to https:// including for some links to external sites in some of the comments, I think there was actually only 1 site that didn't have valid HTTPS.

@sebcrozet sebcrozet merged commit 0384268 into dimforge:dev Jun 11, 2019
@sebcrozet
Copy link
Member

Thanks!

sebcrozet pushed a commit that referenced this pull request Aug 27, 2019
* Use https for all links where it is valid

* Fix random links to external sites
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants