Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Sockets library #7

Closed
fitzgen opened this issue Feb 26, 2019 · 5 comments
Closed

Web Sockets library #7

fitzgen opened this issue Feb 26, 2019 · 5 comments

Comments

@fitzgen
Copy link
Member

fitzgen commented Feb 26, 2019

Let's make an idiomatic, Rust-y interface for working with Web Sockets!

@thedodd
Copy link

thedodd commented Apr 5, 2019

I apparently didn't see this issue when I created #49. Sorry! My search string was websocket without a space, that's probably why I missed it.

@fitzgen what would you like to do with this issue?

@fitzgen
Copy link
Member Author

fitzgen commented Apr 5, 2019

I think it is fine to leave it open as a sort of meta issue until we've got some websockets API(s) in Gloo that we are happy with.

@richard-uk1
Copy link
Contributor

@Pauan I've had a first go at implementing websockets following the gloo pattern in a branch. It works with tests, but I'm not sure the design is perfect yet. Specifically, I'm not sure how much to use the traits from futures (Stream and Sink) and how much to just use our own methods. I'll try to write up the different possibilities with their tradeoffs, but in the mean time I thought you might be interested in my first draft implementation.

@richard-uk1
Copy link
Contributor

I'm just goona bump this thread and make a request for comments on the proposal #113. I'm especially interested in whether it satisfies your use-case? When I have used websockets, it has always been for essentially JSON-RPC, where you send either notifications (messages without a response) or requests (messages that expect a response). I'm wondering in particular if any users have performance requirements and whether this design satisfies them, and also whether the API is as simple as it could be?

@ranile
Copy link
Collaborator

ranile commented Aug 20, 2021

I'm gonna close this issue in favor of #49 as that one has more discussion/activity.

@ranile ranile closed this as completed Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants