Expose a FunctionBuilder through LocalFunction
#54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
force-pushed
the
builder-methods
branch
2 times, most recently
from
78ce925
to
93dfa67
Compare
fitzgen
approved these changes
Feb 15, 2019
|
|
||
| /// Get access to a `FunctionBuilder` to continue adding expressions to | ||
| /// this function. | ||
| pub fn builder(&self) -> &FunctionBuilder { |
There was a problem hiding this comment.
One can't use a shared ref to a function builder to add expressions though, right?
There was a problem hiding this comment.
True! I figured it'd be good to expose in terms of idioms although we can always remove it later
This should allow to continue to build expressions for a function even after it exists
alexcrichton
force-pushed
the
builder-methods
branch
from
93dfa67
to
c3c063e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow to continue to build expressions for a function even
after it exists