Add missing variadic bindings for string methods #1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ah hmm... I should have checked these. Is there any particular reason these slices are not allowed? (while |
RReverser
force-pushed
the
more-variadic
branch
from
5876dcf
to
d863ebc
Compare
|
I've added support for |
|
Oh, hmm, currently bindings assume that they can drop every item of the slice. I see, it's not as easy as seemed initially. |
- `JsString::from_code_point` - allows to create JS strings using slice of codes in WASM memory. - `JsString::from_char_code` - same as above, but also uses updated signature with `u16` instead of `u32` (partially helps with rustwasm#1460 at least for the new binding).
RReverser
force-pushed
the
more-variadic
branch
from
d863ebc
to
85eea18
Compare
RReverser
changed the title
|
Removed the problematic bindings for now, and kept just |
RReverser
changed the title
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JsString::from_code_point- allows to create JS strings using slice of codes in WASM memory.JsString::from_char_code- same as above, but also uses updated signature withu16instead ofu32(partially helps with JsString::from_char_code1 and family should take u16 not u32 #1460 at least for the new binding).