Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bufferSubData and clearBuffer[fiuv] to immutable slice whitelist #1508

Merged
merged 1 commit into from
May 8, 2019
Merged

Conversation

RSSchermer
Copy link
Contributor

@RSSchermer RSSchermer commented May 2, 2019

Adds bufferSubData and clearBuffer[fiuv] to immutable slice whitelist.

Edit: bufferData -> bufferSubData (typo)

@RSSchermer RSSchermer changed the title Add bufferData and clearBuffer[fiuv] to immutable slice whitelist Add bufferSubData and clearBuffer[fiuv] to immutable slice whitelist May 2, 2019
@alexcrichton
Copy link
Contributor

Thanks for the PR! I'm personally pretty unfamiliar with WebGL, but @chinedufn perhaps you'd be willing to take a look to verify this is a correct transformation to apply?

@RSSchermer
Copy link
Contributor Author

Here are some links the the relevant MDN documentation to perhaps help verify that these function indeed don't require and exclusive reference:

@alexcrichton
Copy link
Contributor

Ok yeah sounds like @chinedufn is busy right now so looks good to me!

@alexcrichton alexcrichton merged commit d139228 into rustwasm:master May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants