Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added explicit extension for imported .wasm file for --target bundler #1646

Merged
merged 1 commit into from
Jul 8, 2019
Merged

Added explicit extension for imported .wasm file for --target bundler #1646

merged 1 commit into from
Jul 8, 2019

Conversation

ibaryshnikov
Copy link
Member

Closes #1441

This update is more in line with esm-module integration. At the moment there's a comment near this code:

// With Bundlers and modern ES6 support in Node we can simply import
// the wasm file as if it were an ES module and let the
// bundler/runtime take care of it.

If I get it right, without extension this will not work in node.js

@alexcrichton alexcrichton merged commit 16fc059 into rustwasm:master Jul 8, 2019
@alexcrichton
Copy link
Contributor

Looks good to me, thanks!

I don't think this works for some more esoteric use cases but since this is scoped to just bundlers I think it should work out alright.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explicitly add ".wasm" extension when importing wasm file in bundle target
2 participants