Adjust examples and documentation to thread-aware start
#3248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxpedda
force-pushed
the
main-only-once-4
branch
from
7db25f4
to
dc5241a
Compare
Liamolucko
approved these changes
Feb 2, 2023
|
Oops, I merged this too hastily, I just tested the |
|
I apologize for not actually being able to properly test this myself, I did try to get wasm-pack working but unfortunately I just can't figure out what the issue is. |
Liamolucko
added a commit
to Liamolucko/wasm-bindgen
that referenced
this pull request
Feb 2, 2023
The start function still gets called on every thread in that example because it doesn't actually use wasm multithreading; each thread's instance has it's own separate memory pool and is completely unaware of the other thread. So, attempting to switch it to use a regular start function caused the worker thread to spawn another one, which does likewise, quickly spiralling out of control. It also ended up panicking because, thinking it was the main thread, the code was trying to access `window` inside of a worker.
alexcrichton
pushed a commit
that referenced
this pull request
Feb 2, 2023
The start function still gets called on every thread in that example because it doesn't actually use wasm multithreading; each thread's instance has it's own separate memory pool and is completely unaware of the other thread. So, attempting to switch it to use a regular start function caused the worker thread to spawn another one, which does likewise, quickly spiralling out of control. It also ended up panicking because, thinking it was the main thread, the code was trying to access `window` inside of a worker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't adjust the examples and documentation after #3236.
This addresses that.
I honestly wasn't able to test the
wasm-in-web-workerexample because I couldn't get wasm-pack working.