Skip to content

Conversation

darioalessandro
Copy link
Contributor

@darioalessandro darioalessandro commented Mar 9, 2023

Added WebTransport webidl definitions to the unstable features.

@darioalessandro darioalessandro mentioned this pull request Mar 9, 2023
@darioalessandro
Copy link
Contributor Author

@Liamolucko let me know the next steps 😄

Copy link
Contributor

@Liamolucko Liamolucko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just left one comment about the URL of the WebIDL file being wrong.

I would have asked you to add [Throws] to any functions that can throw, which tells the code generator the function should return a Result, but it turns out that nothing in WebTransport can actually throw anyway, since everything's async and results in a promise rejection or similar instead.

Co-authored-by: Liam Murphy <liampm32@gmail.com>
@darioalessandro
Copy link
Contributor Author

@Liamolucko change applied, thanks for your review 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

web-sys: Support WebTransport as an unstable API
2 participants