Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing CSS loaders for todomvc app #3535

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

snOm3ad
Copy link
Contributor

@snOm3ad snOm3ad commented Jul 27, 2023

Currently webpack does not bundle the index.css file located in the root directory. This PR adds the corresponding plugins and loaders to ensure the file is correctly bundled.

Fixes #3443

Currently webpack does not bundle the index.css file located in the root
directory. This PR adds the corresponding plugins and loaders to ensure
the file is correctly bundled.

Fixes rustwasm#3443
Bumped version of `css-loader` as we're on webpack 5 already.

Signed-off-by: Oliver T <geronimooliver00@gmail.com>
@daxpedda daxpedda added the needs review Needs a review by a maintainer. label Aug 4, 2023
Copy link
Collaborator

@Liamolucko Liamolucko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know a whole lot about Webpack, but this all looks good to me. Thanks!

@Liamolucko Liamolucko merged commit 486238b into rustwasm:main Aug 8, 2023
25 checks passed
@snOm3ad snOm3ad deleted the fix-add-css-todomvc branch August 17, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review Needs a review by a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS missing in compiled todomvc example
3 participants