Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add methods for Typed Array and Array #3888

Merged
merged 5 commits into from
Mar 13, 2024
Merged

Add methods for Typed Array and Array #3888

merged 5 commits into from
Mar 13, 2024

Conversation

swnb
Copy link
Contributor

@swnb swnb commented Mar 12, 2024

  1. add find_last_index and find_last for Array
  2. add copy_within for Typed Array

daxpedda
daxpedda requested changes Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs an entry in the changelog.
Otherwise LGTM, thank you for adding tests as well!

@swnb swnb requested a review from daxpedda March 13, 2024 13:41
daxpedda
daxpedda approved these changes Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@daxpedda daxpedda merged commit b3121a6 into rustwasm:main Mar 13, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxpedda daxpedda daxpedda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swnb @daxpedda