Add wasmbindgen option: omit_default_module_path
#1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drager
reviewed
May 30, 2023
CHANGELOG.md
Outdated
Comment on lines
1034
to
1035
| # Should we omit the default import path? | ||
| omit-default-module-path = false |
There was a problem hiding this comment.
I don't think the old changelog should be edited.
There was a problem hiding this comment.
Oops 🙈 Thanks for catching this one 🙏 Added a revert commit for CHANGELOG.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently no option to run
wasm-bindgenwith--omit_default_module_path.This is relevant for projects that run in a context where usage of
input = new URL('file.wasm', import.meta.url);is causing problems (e.g., in web workers).This PR adds the option to run
wasm-bindgenwith--omit_default_module_path.Reference: https://rustwasm.github.io/wasm-bindgen/reference/cli.html?highlight=omit#--omit-default-module-path