Array view instead of direct wasm memory access #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.cells.as_ptr() | ||
| pub fn cells(&self) -> js_sys::Uint8Array { | ||
| unsafe { | ||
| let u8_cells = mem::transmute::<&Vec<Cell>, &Vec<u8>>(&self.cells); |
There was a problem hiding this comment.
I think this can avoid transmute here and instead cast the slice to pointer, convert the pointer, and construct a new slice from that:
let u8_cells: &[u8] = unsafe {
let ptr = self.cells.as_ptr() as *const u8;
let bytelen = self.cells.len() * std::mem::size_of::<Cell>();
std::slice::from_raw_parts(ptr, bytelen)
};
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Talking on discord I've learned that directly accessing wasm's linear memory to efficiently share data between the universes is not necessary anymore, because
js_sysnow has a view method for JavaScripts typed Arrays that does exactly that. To help other coders know about that feature, and more obviously show that this is unsafe code potentially, I adapted the code to use the view instead.