Added optional chaining operator support #93
+318
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for normal indexing, computed indexing and function calls
|
moved some parsing code to extra functions to avoid duplicated code in case of parsing as optional or without optional operator |
|
found some code that does not parse correctly: it seems this is a ternary operator + specification of a floating point number without the leading zero, which gets interpreted as the optional chaining operator now. I wonder if we have to look ahead now for the matching ":" and then decide if its ternary or optional chaining operator. |
|
Good catch! I think we we might be able to get away with a check that the character after ?. is an ident_start. I can try and play around with that in ress this weekend |
|
Ah, I thought its actually from my RESSA code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for normal indexing, computed indexing and function calls