added support for optional chaining and optional calls #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FreeMasen
reviewed
Mar 29, 2024
There was a problem hiding this comment.
nice! Thank you for taking a stab at this!
This looks mostly good to me, though I believe we will need to make similar changes in the non-spanned module and update the impl From<spanned::Expr> for crate::Expr to account for the new entries
|
oh true, I didn't considered the non-spanned module. You want to keep the non spanned stuff to have an option to be more performant I imagine? |
|
added the optional chaining to the non-spanned module. Also fixed/improved tests for RESSA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.