Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporal sampling #202

Merged
merged 25 commits into from
Apr 22, 2022
Merged

Temporal sampling #202

merged 25 commits into from
Apr 22, 2022

Conversation

RexYing
Copy link
Contributor

@RexYing RexYing commented Feb 8, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2022

Codecov Report

Merging #202 (c50f595) into master (eafcfe0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #202   +/-   ##
=======================================
  Coverage   72.32%   72.32%           
=======================================
  Files          28       28           
  Lines        1120     1120           
=======================================
  Hits          810      810           
  Misses        310      310           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@ZenoTan
Copy link
Contributor

ZenoTan commented Apr 7, 2022

Since the random function has been changed to follow torch.random, rand() could be replaced with #217

@ZenoTan
Copy link
Contributor

ZenoTan commented Apr 20, 2022

Is it because the pytorch 1.11 (on ubuntu) has made some modifications on data_ptr API so the test failed? cc @rusty1s
Another way to try is a single .data_ptr() without template and cast the pointer afterwards, but I'm not sure if it should work.

Copy link
Owner

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RexYing. This looks great overall. One thing I think we need to fix is to add is_temporal as part of the template definition.

csrc/cpu/neighbor_sample_cpu.cpp Outdated Show resolved Hide resolved
csrc/cpu/neighbor_sample_cpu.cpp Outdated Show resolved Hide resolved
csrc/cpu/neighbor_sample_cpu.cpp Outdated Show resolved Hide resolved
csrc/cpu/neighbor_sample_cpu.cpp Outdated Show resolved Hide resolved
csrc/cpu/neighbor_sample_cpu.cpp Outdated Show resolved Hide resolved
csrc/cpu/neighbor_sample_cpu.cpp Show resolved Hide resolved
csrc/cpu/neighbor_sample_cpu.cpp Outdated Show resolved Hide resolved
csrc/cpu/neighbor_sample_cpu.cpp Outdated Show resolved Hide resolved
csrc/cpu/neighbor_sample_cpu.h Show resolved Hide resolved
node_types, edge_types, colptr_dict, row_dict, input_node_dict,
num_neighbors_dict, node_time_dict, num_hops, replace, directed);
}

static auto registry =
torch::RegisterOperators()
.op("torch_sparse::neighbor_sample", &neighbor_sample)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How much work would it be to add the same for neighbor_sample?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be easy. I'll create another PR for neighbor_sample?

RexYing and others added 6 commits April 21, 2022 16:12
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
@rusty1s rusty1s merged commit 79535f3 into rusty1s:master Apr 22, 2022
RexYing pushed a commit to RexYing/pytorch_sparse that referenced this pull request Apr 26, 2022
* nni basic

* nni basic trial

* Ray tune now works

* create separate kumo-train-auto

* update

* fix

* fix

* fix

* Update and merge single/tune API

* fix linting

* Fix pl api change

* Ready to merge with master

* Add missing file

* Refactor train_fn, improve test_trainer

* fix

* fix

* Final change based on comments

* Fix conflict

Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants