use batch idx and node id as unique key for dedup in temporal sampling #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RexYing
reviewed
Aug 10, 2022
Codecov Report
@@ Coverage Diff @@
## master #267 +/- ##
=======================================
Coverage 72.32% 72.32%
=======================================
Files 28 28
Lines 1120 1120
=======================================
Hits 810 810
Misses 310 310 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
RexYing
approved these changes
Aug 11, 2022
yanbing-j
pushed a commit
to yanbing-j/pytorch_sparse
that referenced
this pull request
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would fix the issue where we sample the same node multiple times and blow up batch size.