refactor: logging cleanup

rustymotors · Nov 2, 2021 · 40e1e40 · 40e1e40
1 parent f3b1b9c
commit 40e1e40
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/packages/lobby/src/index.ts b/packages/lobby/src/index.ts
@@ -195,8 +195,10 @@ export class LobbyServer {
         try {
           return npsSocketWriteIfOpen(connection, responsePacket.serialize());
         } catch (error) {
-          process.exitCode = -1;
-          throw new Error(`Unable to send Connect packet: ${error}`);
+          if(error instanceof Error) {
+            throw new Error(`Unable to send Connect packet: ${error}`);
+          }
+          throw new Error(`Unable to send Connect packet: unknown error`)
         }
       }
 

diff --git a/packages/transactions/src/tcp-manager.ts b/packages/transactions/src/tcp-manager.ts
@@ -245,7 +245,7 @@ export class TCPManager implements ITCPManager {
           return this.socketWriteIfOpen(result.connection, responsePackets);
         } catch (error) {
           if (error instanceof Error) {
-            throw new TypeError(`Error in MC_TRACKING_MSG: ${error}`);
+            throw new TypeError(`Error in MC_TRACKING_MSG: ${error.message}`);
           }
 
           throw new Error("Error in MC_TRACKING_MSG, error unknown");
@@ -261,7 +261,7 @@ export class TCPManager implements ITCPManager {
           return this.socketWriteIfOpen(result.connection, responsePackets);
         } catch (error) {
           if (error instanceof Error) {
-            throw new TypeError(`Error in MC_UPDATE_PLAYER_PHYSICAL: ${error}`);
+            throw new TypeError(`Error in MC_UPDATE_PLAYER_PHYSICAL: ${error.message}`);
           }
 
           throw new Error("Error in MC_UPDATE_PLAYER_PHYSICAL, error unknown");
@@ -279,7 +279,7 @@ export class TCPManager implements ITCPManager {
         } catch (error) {
           if (error instanceof Error) {
             throw new TypeError(
-              `[TCPManager] Error writing to socket: ${error}`,
+              `[TCPManager] Error writing to socket: ${error.message}`,
             );
           }
 
@@ -320,7 +320,7 @@ export class TCPManager implements ITCPManager {
         } catch (error) {
           if (error instanceof Error) {
             throw new TypeError(
-              `[TCPManager] Error writing to socket: ${error}`,
+              `[TCPManager] Error writing to socket: ${error.message}`,
             );
           }
 
@@ -363,7 +363,7 @@ export class TCPManager implements ITCPManager {
         } catch (error) {
           if (error instanceof Error) {
             throw new TypeError(
-              `[TCPManager] Error writing to socket: ${error}`,
+              `[TCPManager] Error writing to socket: ${error.message}`,
             );
           }