npm ignore the tests #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, but we believe that tests are a primary form of documentation, and they should be released with the library. This is not a lot of data, gzipped. |
|
Sure, it's not a lot of code. But bytes can add up. And if someone is using your library, can't they just look at the tests on github? The real reason I made this PR is because we are trying to scrub our codebase of all instances of any md5 hashing, and the tests include md5 hashes. While the tests are not being invoked, the md5 invocations are still there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this .npmignore, the
testdirectory won't be included with the vendor dependencies, reducing the size of the module when used by other projects. Pretty cool, huh?