Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: use 'standard', minor formatting & syntax changes #75

Merged
merged 1 commit into from
Sep 19, 2019

Conversation

rvagg
Copy link
Owner

@rvagg rvagg commented Sep 18, 2019

Also includes the changes in #74, so the last commit is the new thing here.

standard is hooked up for "lint" and "test". I've also done some additional formatting fixes, mainly adding newlines and whitespace. The style should be easier to grok now and standard is getting pretty comprehensive so that should help with contributions.

Proposing that this gets released as 4.0.0. There's nothing strictly breaking in here if you're using it as documented but it does feel like the safe choice.

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rvagg rvagg merged commit cadb542 into master Sep 19, 2019
@rvagg rvagg deleted the rvagg/standard branch September 19, 2019 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants